The second half of Insomnia revolves mainly around this.
The Spawn movie is about a bargain with the devil which ends in the nearly total devastation of the former when the protagonist successfully uses newly acquired powers against the one who gave them.
In Santa's Slay, one of God's angels beats Santa, the son of Satan, and Santa must remain good for 1,000 years.
The Star Wars prequels have this with Anakin Skywalker and Chancellor Palpatine. Anakin's desire for Padmé Amidala's-life-spared-at-any-cost might not have been spelled out and Palpatine himself might not be the devil, but otherwise the trope is played to the hilt.
There's also Lando Calrissian's deal with Darth Vader in The Empire Strikes Back. Lando really had no choice about it - the Dark Lord of the Sith showed up and would have destroyed Cloud City if he'd been refused. The Falcon and her crew would be betrayed and captured to draw in Luke Skywalker; Han Solo would be frozen in carbonite and handed off to Boba Fett, the rest of the crew would never leave Cloud City, and then The Empire would leave and ignore Lando's operation. Vader altered the deal, and eventually Lando did too.
And Return of the Jedi lampshades ("Strike me down. Then your journey to The Dark Side will be complete.") and subverts it. There's even an Alternative Character Interpretation where Luke and Vader planned how it would play out before they ever met Ol' Sidious, so Vader made a deal with Luke. But it's Star Wars, it plays with every mythology trope ever.
About the deal between Anakin and Palpatine in Revenge of the Sith...Palpatine had told Anakin that Darth Plagueis was his master (in the books) and that he could teach Anakin the technique Darth Plagueis used to extend the life of whomever he chose to effectively eternity. Even though Anakin effectively sold his soul to Palpatine to save Padmé from possible death, the deal failed for two reasons. 1. Anakin ended up killing his own wife, or at least contributing to it, so he had no wife to save. 2. In the books, Palpatine reveals in his thoughts that he had never learned the technique Darth Plagueis had, and Palpatine ended up having to resort to making clones and the Sith technique of transferring his soul into another body just to extend his own life. Turns out, that said technique for saving people's lives is all just a plain old lie. Yep, Anakin was effectively left with nothing as a result of the deal.
Tenacious D's movie, Tenacious D in The Pick of Destiny, has Kage and Jables cutting a deal with Satan: if they win a rock off against him, he has to go back to Hell and pay their rent. If Satan wins, Kage has to go back to Hell with Satan and be his sex slave. They wind up beating him through a technicality: if Satan is ever "incomplete" (i.e. missing a part of himself, like a tooth or horn), a spell can be used to send him back automatically.
The rock-off is a parody of many other versions where the mortals can actually compete successfully against the Devil.
Both versions of the film Bedazzled 1967 — the original and the remake — concern a deal with the Devil in exchange for seven wishes. In the remake, the main character is eventually freed from the contract by making an unselfish wish. However, he could never collect the soul in the first place, since they belong to God. She was just mindscrewing the character.
The films features Davy Jones, a sort of Devil of the Sea. He makes deals with dead or dying sailors, offering them a 100 year postponement of death in return for serving on his crew. He also made a deal with Jack Sparrow, making him Captain of the Black Pearl for 13 years in return for his promise to serve. Sparrow manages to weasel his way out, almost. "Not even Jack Sparrow can best the Devil!" Although, as the writers' commentary points out, Davy Jones doesn't exactly win by the end, either.
Jack himself counts. "Spring me from this cell and I will take you to the Black Pearl and your bonnie lass." While he does deliver on his end, it was for his selfish benefit and he fully intended on selling Will out. For his part, Will becomes wrapped up in the world of pirates and has to fight and scrap just to earn a Bitter Sweet Ending.
The Godfather opens with an undertaker asking for Vito Corleone to avenge his brutalized daughter. Corleone criticizes the man for only visiting him when he has a favor to ask, and claims a debt in return, saying, "Someday, and that day may never come, I will call upon you to do a service for me. Until that day, accept this justice as a gift on my daughter's wedding day." The unspecified nature of the debt makes the undertaker nervous, but in the end, the undertaker is called upon to reconstruct the face of the Don's son, Sonny Corleone, who was savagely murdered. In the book, it's revealed that the Don usually limits himself to free services such as this, rather than more insidious favors.
Towards the end of Phantom of the Paradise, we learn that Swan made a deal with the devil to stay youthful forever and to be a super-successful record producer. Swan's end of the deal is that he must record every day of his life on film and rewatch every reel every day. If the film is destroyed, then Swan will die. When the phantom learns this, he promptly sets all of the film on fire.
The Wishmaster films are all about this trope. Not only does the Djinn take your soul in exchange for a wish (a condition he apparently is not obliged to disclose to you in advance) but he will always grant the wish in a "Monkey's Paw" form. What's more, he can close the deal if you merely speak a wish out loud in his presence.
In The Devil and Daniel Webster, a good but rather dumb and weak man makes a deal with the devil. He gets the money he needs for his farm (and way more,) and in seven years the devil will claim his soul. The man agrees after the devil assures him that "souls are not important." After seven years he's had a son (and neglected him), got a servant that acted as his mistress, hired his former friends and taken advantage of them, and become a Jerkass while still being the dumbest man on earth. Later, Daniel Webster comes and manages to let him weasel out of the deal.
Freddy began his horror career with one of these according to Freddy's Dead: The Final Nightmare, offered his powers and immortality by a trio of "dream demons" who choose a human villain as their Psycho for Hire every thousand years. If they had any plan to betray him, it must've been scheduled for after he'd already brought about The End of the World as We Know It: as it is, the price he seems to have paid for his deal is that whatever shred of goodness he had as a human went completely out the window.
Accepting the Mark of the Beast in the Apocalypse film series is played out like this, with the benefits of its recipients experiencing miracles such as the blind woman in Revelation receiving her sight, the wheelchair-bound man in the same movie being able to walk, and the one-armed man in the hospital in Tribulation receiving his right arm again. There's also the Blessed with Suck element of having limited telepathic and telekinetic powers, as featured in Tribulation.
Little Shop of Horrors has the devil in the form of an unusual carnivorous plant that feeds on blood. The little nerdy guy who discovers it, Seymour, is promised fame and fortune if he keeps feeding the plant; this does come, just from people who think he's an amazing gardener and who want to examine his plant. He first sacrifices an Asshole Victim (his would-be girlfriend's abusive boyfriend) to the plant, then the shop owner Mr. Mushnik when Mushnik turns on him. The plant grows to immense size and tries to devour Audrey; Seymour gets devoured as well in most versions except for the one time the movie has a happy ending, with him electrocuting and destroying the plant.
Disney Channel Original Movie Luck Of The Irish involves the protagonist Kyle Johnson making a deal with a far darrig named Seamus that whoever won a series of games would get the lucky gold coin, and Seamus would have to forever go to Erie, the shores of [Kyle's] forefathers. Seamus thinks that Kyle is mispronouncing Eire, a nickname for Ireland; but Kyle's paternal family is from Ohio which borders Lake Erie.
The movie Demon Knight has The Collector, a mid level demon, trying to acquire a rare artifact that will bring about the end of the universe. The only way he can get inside the house where the artifact resides is by tempting everyone inside with their various fantasies. In the end, whoever accepts the fantasy or (in one case) tries to turn traitor to the group by just handing it over, doesn't receive what The Collector promised them and just turns into another low level demon.
In End of Days, Jericho's best friend is strong-armed into serving Satan after Satan sets him on fire. Near the end of the film, Jericho begs his friend to not betray him again, saying that he's better than that. The moment he lowers his gun, Satan reminds him that they had a deal, and he sets him on fire again.
In the film version of the Hellblazer comic above, Constantine, the titular character kills himself a second time to summon Lucifer to claim his soul. But while talking, Constantine reveals the plan of Big Bad, which screws with Lucifer's plans. So Lucifer stops it easily. Annoyed he is in debt to Constantine, he is the one starting the deal and offers him more life. Constantine would like instead the soul of a woman who committed suicide free to be in heaven. An easy bargain and Lucifer smiles but soon realizes Constantine is rising to heaven as he died to save the world. So, he cures Constantine's cancer and wrist wounds, forcing him to live. Oh, and when rising, Constantine, or maybe God controlling the hand, flips off the Devil.
In Angel Heart, Johnny Favorite selling his soul for stardom and then trying to get out of it by sacrificing an innocent man caused the whole plot.
Harrison promises Thomas Harewood he can save the man's comatose daughter in the opening of Star Trek: Into Darkness. In exchange, Thomas blows up a Starfleet facility shortly after messaging a confession for the bombing (with credit to Harrison) to Admiral Marcus.
Hinted at in The Shining during the bar scene. Jack says he'd give his soul for a drink, cue creepy bartender appearing with a full stock of booze.
As Erik in The Phantom of the Opera (1989) watches Faust at the opera, he has a flashback that shows that he sold his soul to the Devil so that his music would become immortal like Mozart's and Beethoven's.