Cry for the Devil: When Scaramanga worked as a child in his father's circus, his only friend was an elephant he took care of. When a policeman shot the elephant, Scaramanga murdered the policeman and so began his life of crime.
Damsel Scrappy: Mary Goodnight is among the least popular girls from the Bond franchise.
Evil is Cool: Scaramanga. Being played by Christopher Lee really helps here. Because of this trope, the villain is often regarded as one of the best things in the movie.
Foe Yay: Between Bond and Scaramanga, mostly one-sided. Scaramanga may like the ladies, but he also seems to have a bit of a guy crush on Bond, just enough to qualify as Ho Yay.
Heartwarming Moments: Meta-example. Christopher Lee died in 2015. For the In Memorium segment at the following Oscars, the clip for him was a line from this film (considered one of the lesser Bond outings) that nonetheless completely encapsulates the life and work of Sir Christopher Lee.
As Scaramanga shows off his high-tech lair to Bond, he tells him that he cannot explain its finer points, as science isn't really his thing. Years later in the Licensed GameGoldenEye: Rogue Agent, he is quite the opposite, as he is made into an Evil Counterpart of Q, and his job is to come up with the all the cool gadgets for the protagonist. This is actually much closer to his characterization in the novel.
Maud Adams character is killed after having sex with Bond - and specifically because she had sex with Bond, which Scaramanga did not appreciate. Years later Maud Adams played the title character in Octopussy where she thinks that Bond dies horribly after having sex with her, but fortunately he survives.
Idiot Plot: Much of the movie, particularly the final third, could've been avoided if Goodnight wasn't so stupid. Also, the entire sequence in Beirut — why did Bond need the slug that killed 002 when he already had an intact bullet sent to him? He could have gone straight to Macau, and the film likely would have been better.
Lulu's completely insane title song straddles the line between this and Narm Charm.
Bond swallowing the golden slug that the belly dancer used as a charm, and then having to have his stomach pumped to retrieve the bullet to show to Q back in London. An entirely useless sequence, and probably the most laughably idiotic thing to happen to Bond.
Never Live It Down: The infamous slide whistle sound effect placed over the famous barrel roll scene remains a constant target of mockery for most critics of this film.
Padding: The film is prolonged by pointless meandering in a few cases. For example, why Bond had to get the bullet in Beirut when he had the one sent to him, the Kung Fu scene and its following canal chase etc.
They Wasted a Perfectly Good Plot: Sort of. Although the climax of the film is by no means bad, the concept of Bond and Scaramanga having a showdown should have been a LOT more suspenseful and dramatic. Instead, Scaramanga spends almost the entire duel running away and leaving Bond to traverse his funhouse, before being shot before he manages to even pull the trigger.
Not to mention Sir Christopher was a member of the SOE during World War II, working with Ian Fleming and being one of the inspirations for 007. In short, we had a real James Bond going up against James Bond himself! The duel should have been far more epic than it was!
Values Dissonance: The depiction of women in the series bottoms-out into outright misogyny in this one. In this it follows a trend; earlier entries may have had dated Gender Roles by contemporary standards, but they still managed to find a place for badass women like Pussy Galore and Tracy Bond. Beginning with Diamonds Are Forever, the Bond Girls degraded into Shrinking Violets, and by Man With the Golden Gun, we've devolved into Bond brutalizing Scaramanga's Sex Slave Andrea Anders (Who subsequently dies a cruel and sudden death with little fanfare), and Mary Goodnight, as stereotypical a Dumb Blonde as you're likely to see. Fortunately, this trend would reverse with the very next entry in the series, The Spy Who Loved Me.
Vindicated by History: A very minor example. Although it still is regarded as cringe-inducingly camp at times, the film's theme of duality has been commended in recent years, as has its villain, Moore's performance, and even its pace, despite the arguable Padding.
Take That, Audience!: Pulp adventure novels like the James Bond stories had (and have) a strong appeal to veterans and gun owners. The psychological profile of Scaramanga basically says, "If you're a gun enthusiast, even a target shooter, you've got a penis problem."
They Wasted a Perfectly Good Plot: A brainwashed James Bond working for Soviet Union is an interesting story itself, but it is quickly undone so that he can be put against Scaramanga, who is essentially just a glorified thug whose grand plan is to build a hotel.